feat(cli): UTExportedTypeDeclarations support for file associations - #12
Conversation
|
|
||
| if association.ext.is_empty() { | ||
| dict.insert( | ||
| "CFBundleTypeExtensions".into(), |
There was a problem hiding this comment.
Bug: The condition if association.ext.is_empty() is inverted. It prevents file extensions from being added to the macOS bundle's Info.plist when they are present.
Severity: CRITICAL
Suggested Fix
Invert the condition to correctly add the extensions when the list is not empty. Change if association.ext.is_empty() to if !association.ext.is_empty().
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: crates/tauri-bundler/src/bundle/macos/app.rs#L330
Potential issue: The code checks `if association.ext.is_empty()` before adding
`CFBundleTypeExtensions` to the macOS application's `Info.plist`. This logic is
inverted. When `association.ext` contains extensions, the `if` block is skipped, and the
extensions are never registered. When `association.ext` is empty, an empty array is
added. This will cause file associations to fail on macOS for applications that define
them, as the operating system will not be aware of the file types the application can
handle.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#12