fix: a few regressions from previous PRs - #10
Open
tomerqodo wants to merge 5 commits into
Conversation
| *self.window_id.lock().unwrap(), | ||
| self.webview_id, | ||
| WebviewMessage::DeleteCookie(cookie.clone().into_owned()), | ||
| WebviewMessage::SetCookie(cookie.into_owned()), |
There was a problem hiding this comment.
Bug: The delete_cookie function incorrectly sends a WebviewMessage::SetCookie message, which causes cookies to be set or updated instead of deleted.
Severity: HIGH
Suggested Fix
In the delete_cookie function, change the message being sent from WebviewMessage::SetCookie(cookie.into_owned()) to WebviewMessage::DeleteCookie(cookie.into_owned()) to ensure the correct delete operation is invoked.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: crates/tauri-runtime-wry/src/lib.rs#L1718
Potential issue: In `crates/tauri-runtime-wry/src/lib.rs`, the `delete_cookie` function
incorrectly sends a `WebviewMessage::SetCookie` message instead of the expected
`WebviewMessage::DeleteCookie`. This means that when an application calls the
`delete_cookie()` API, the cookie will be set or updated rather than removed. This
breaks the core functionality of deleting cookies and could lead to security issues
where sensitive cookies cannot be properly cleared.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#10