feat(core): back button event on Android, closes #8142 - #6
Open
Conversation
🤖 Augment PR SummarySummary: Adds Android back-button handling through a new mobile core app plugin and exposes it in the JS API. Changes:
Technical Notes: The event payload exposes whether the WebView can navigate back so JS can decide whether to navigate or exit; default behavior remains when no listener is registered. 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
| } | ||
| } | ||
| (activity as AppCompatActivity).onBackPressedDispatcher.addCallback(activity, callback) |
There was a problem hiding this comment.
This hard-casts the host activity to AppCompatActivity, which will crash at runtime if a non-AppCompatActivity ever constructs this plugin. Also, addCallback(activity, ...) relies on the argument being a LifecycleOwner, so it may be worth ensuring the same AppCompatActivity instance is used for registration.
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#6