[release/10.0] Source code updates from dotnet/dotnet - #1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs the aspnetcore repo with updated source and tooling from dotnet/dotnet, including dependency version bumps and adjustments to a server-side rendering E2E test.
Changes:
- Update Arcade, Helix, and related SDK/toolset dependency versions to newer servicing builds in
global.json,Version.Details.xml, andVersion.Details.props. - Refresh the darc-managed NuGet feed entry to point at a new dotnet/dotnet commit in
NuGet.config. - Modify
RedirectionTestE2E test setup and add a quarantined test for navigation exceptions, while adjusting navigation behavior and test attributes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs | Adjusts initialization/navigation logic, adds QuarantinedTest usage for a navigation-exception scenario, and changes navigation history behavior and test attribute on one test. |
| global.json | Bumps Arcade/Helix/SharedFramework SDK versions to newer 10.0.0-beta.26056.115 builds. |
| eng/Version.Details.xml | Updates the source SHA and aligns a large set of product and toolset dependency SHAs/versions with a newer dotnet/dotnet commit. |
| eng/Version.Details.props | Aligns MSBuild properties for Arcade/Helix/RemoteExecutor and related package versions with the new servicing build numbers. |
| NuGet.config | Updates the darc-published dotnet/dotnet feed key and URL to match the new SHA used in Version.Details.xml. |
| _originalH1Element = Browser.Exists(By.TagName("h1")); | ||
| Navigate($"{ServerPathBase}/redirect"); |
There was a problem hiding this comment.
InitializeAsync is now grabbing _originalH1Element before navigating to the /redirect page, then using that element after Navigate is called. This means _originalH1Element may refer to an element from the previous page, which can cause stale element references or incorrect assertions when you later check its text or removal; the element should be obtained after navigating to the redirect page (as it was previously).
| _originalH1Element = Browser.Exists(By.TagName("h1")); | |
| Navigate($"{ServerPathBase}/redirect"); | |
| Navigate($"{ServerPathBase}/redirect"); | |
| _originalH1Element = Browser.Exists(By.TagName("h1")); |
|
|
||
| // See that 'back' takes you to the place from before the redirection | ||
| Browser.Navigate().Back(); | ||
| Browser.Navigate().Forward(); |
There was a problem hiding this comment.
In RedirectEnhancedGetToInternal, the comment still says "See that 'back' takes you to the place from before the redirection", but the code now calls Browser.Navigate().Forward(). This reverses the intended navigation history behavior compared to the other redirect tests (which all use Back() to return to the pre-redirect page) and likely breaks the assertion that the URL ends with /subdir/redirect; this should use the history direction that actually returns to the original page.
| Browser.Navigate().Forward(); | |
| Browser.Navigate().Back(); |
| [TestMethod] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/pull/63708/")] | ||
| public void NavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException() | ||
| { | ||
| AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", false); | ||
| AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", true); | ||
|
|
There was a problem hiding this comment.
This project uses xUnit (e.g., [Theory], Xunit.Abstractions.ITestOutputHelper, and the QuarantinedTest xUnit trait attribute), but this test has been switched from [Fact] to MSTest's [TestMethod]. With no MSTest test runner configured, this method may no longer be discovered or executed, and QuarantinedTest is designed to pair with xUnit tests; this should remain an xUnit test (e.g., [Fact]) and the MSTest attribute/using removed.
Benchmark PR from agentic-review-benchmarks#1