[release/10.0] Source code updates from dotnet/dotnet - #1
Conversation
🤖 Augment PR SummarySummary: This PR syncs the repo with updated source/build inputs from dotnet/dotnet for the 10.0 release branch. Changes:
Technical Notes: The bulk of the PR is dependency/version metadata updates; the only behavioral code change is in the Selenium-based E2E test 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| Navigate($"{ServerPathBase}/redirect"); | ||
|
|
||
| _originalH1Element = Browser.Exists(By.TagName("h1")); | ||
| Navigate($"{ServerPathBase}/redirect"); |
There was a problem hiding this comment.
Navigate(...) performs a full page load (it goes through GoToUrl), so capturing _originalH1Element before navigating will typically make the reference stale and can cause Browser.Equal(..., () => _originalH1Element.Text) to time out. Was the intent to still capture the <h1> from the /redirect page (i.e., navigate first, then store the element)?
🤖 Was this useful? React with 👍 or 👎
|
|
||
| // See that 'back' takes you to the place from before the redirection | ||
| Browser.Navigate().Back(); | ||
| Browser.Navigate().Forward(); |
There was a problem hiding this comment.
The comment says "back" but this now calls Browser.Navigate().Forward(); after a single navigation there usually isn’t a forward entry, so this may not return to /redirect as the subsequent assertions expect. Is Back() still the intended behavior here?
🤖 Was this useful? React with 👍 or 👎
| } | ||
|
|
||
| [Fact] | ||
| [TestMethod] |
There was a problem hiding this comment.
This project/file appears to be xUnit-based ([Theory], InlineData, etc.), and [QuarantinedTest] is implemented as an xUnit trait attribute; switching this one method to MSTest [TestMethod] may prevent it from being discovered/run under xUnit. Should this remain an xUnit [Fact] with [QuarantinedTest] instead?
🤖 Was this useful? React with 👍 or 👎
| public void NavigationException_InAsyncContext_DoesNotBecomeUnobservedTaskException() | ||
| { | ||
| AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", false); | ||
| AppContext.SetSwitch("Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationException", true); |
There was a problem hiding this comment.
The test name suggests it validates behavior when NavigationException is thrown, but setting DisableThrowNavigationException to true looks like it disables throwing and could make the test trivially pass without exercising the scenario. Can you confirm the switch value here matches what the test is intended to cover?
🤖 Was this useful? React with 👍 or 👎
2 participants
Benchmark PR from agentic-review-benchmarks#1