transports: Revisions on streamable-http/ws transport request patterns#1064
Merged
benbrandt merged 2 commits intoApr 23, 2026
Conversation
benbrandt
approved these changes
Apr 23, 2026
auto-merge was automatically disabled
April 23, 2026 14:43
Head branch was pushed to by a user without write access
alexhancock
force-pushed
the
alexhancock/streamable-http-ws-request-pattern-revisions
branch
from
5353b86 to
1d7cb75
Compare
Contributor
Author
|
(@benbrandt just pushed a one line formatting thing after your approve) |
auto-merge was automatically disabled
April 23, 2026 14:53
Head branch was pushed to by a user without write access
alexhancock
added a commit
to aaif-goose/goose
that referenced
this pull request
Apr 23, 2026
Implements the 2026-04-23 revision of the Streamable HTTP & WebSocket transport RFD: agentclientprotocol/agent-client-protocol#1064 - Two-header identity model: Acp-Connection-Id (returned at initialize) and Acp-Session-Id (required on session-scoped POSTs). - Single long-lived GET SSE stream per connection carries all server→client messages (responses, notifications, and server-initiated requests), demuxed by client via sessionId in the JSON-RPC body. - POST initialize returns 200 OK with the initialize response JSON body and Acp-Connection-Id header. All other POSTs return 202 Accepted immediately; the agent's response is delivered on the GET stream. - Introduces a shared ConnectionRegistry used by both HTTP and WebSocket handlers, backed by a broadcast channel for fan-out to SSE/WS sinks. - WebSocket upgrade on the same /acp endpoint attaches to the same connection abstraction. - DELETE /acp tears down the connection and aborts the agent task. Signed-off-by: Alex Hancock <alexhancock@block.xyz>
alexhancock
added a commit
to aaif-goose/goose
that referenced
this pull request
Apr 23, 2026
Implements the 2026-04-23 revision of the Streamable HTTP & WebSocket transport RFD: agentclientprotocol/agent-client-protocol#1064 - Two-header identity model: Acp-Connection-Id (returned at initialize) and Acp-Session-Id (required on session-scoped POSTs). - Single long-lived GET SSE stream per connection carries all server→client messages (responses, notifications, and server-initiated requests), demuxed by client via sessionId in the JSON-RPC body. - POST initialize returns 200 OK with the initialize response JSON body and Acp-Connection-Id header. All other POSTs return 202 Accepted immediately; the agent's response is delivered on the GET stream. - Introduces a shared ConnectionRegistry used by both HTTP and WebSocket handlers, backed by a broadcast channel for fan-out to SSE/WS sinks. - WebSocket upgrade on the same /acp endpoint attaches to the same connection abstraction. - DELETE /acp tears down the connection and aborts the agent task. Signed-off-by: Alex Hancock <alexhancock@block.xyz>
alexhancock
added a commit
to aaif-goose/goose
that referenced
this pull request
Apr 23, 2026
Implements the 2026-04-23 revision of the Streamable HTTP & WebSocket transport RFD: agentclientprotocol/agent-client-protocol#1064 - Two-header identity model: Acp-Connection-Id (returned at initialize) and Acp-Session-Id (required on session-scoped POSTs). - Single long-lived GET SSE stream per connection carries all server→client messages (responses, notifications, and server-initiated requests), demuxed by client via sessionId in the JSON-RPC body. - POST initialize returns 200 OK with the initialize response JSON body and Acp-Connection-Id header. All other POSTs return 202 Accepted immediately; the agent's response is delivered on the GET stream. - Introduces a shared ConnectionRegistry used by both HTTP and WebSocket handlers, backed by a broadcast channel for fan-out to SSE/WS sinks. - WebSocket upgrade on the same /acp endpoint attaches to the same connection abstraction. - DELETE /acp tears down the connection and aborts the agent task. Signed-off-by: Alex Hancock <alexhancock@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in the Transports WG Zulip here is a revision to the request patterns for consideration.
Summary
Acp-Connection-Idscoped GET stream delivers all server -> client responses and messages within a connectioncc @anna239 @benbrandt