fix(codex): catch up to rust-v0.123.0 (experimental_thread_store_endpoint) #772
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -152,6 +152,7 @@ const KNOWN_CONFIG_TOP_LEVEL_KEYS: &[&str] = &[ | |||||||||||||||
| "experimental_realtime_ws_base_url", | ||||||||||||||||
| "experimental_realtime_ws_model", | ||||||||||||||||
| "experimental_realtime_ws_startup_context", | ||||||||||||||||
| "experimental_thread_store_endpoint", | ||||||||||||||||
|
Contributor
There was a problem hiding this comment. The addition of References
|
||||||||||||||||
| "experimental_use_freeform_apply_patch", | ||||||||||||||||
| "experimental_use_unified_exec_tool", | ||||||||||||||||
| "features", | ||||||||||||||||
|
|
@@ -2204,6 +2205,15 @@ mod tests { | |||||||||||||||
| ) | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| fn validate_config_json(content: &str) -> Vec<Diagnostic> { | ||||||||||||||||
| let validator = CodexValidator; | ||||||||||||||||
| validator.validate( | ||||||||||||||||
| Path::new(".codex/config.json"), | ||||||||||||||||
| content, | ||||||||||||||||
| &LintConfig::default(), | ||||||||||||||||
| ) | ||||||||||||||||
|
Comment on lines
+2209
to
+2214
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| fn validate_config_with_config(content: &str, config: &LintConfig) -> Vec<Diagnostic> { | ||||||||||||||||
| let validator = CodexValidator; | ||||||||||||||||
| validator.validate(Path::new(".codex/config.toml"), content, config) | ||||||||||||||||
|
|
@@ -3154,6 +3164,48 @@ url = "https://example.com/marketplace" | |||||||||||||||
| ); | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| #[test] | ||||||||||||||||
| fn test_codex_v0_123_top_level_keys_accepted_toml() { | ||||||||||||||||
| // Codex CLI rust-v0.123.0 added 1 new top-level config key | ||||||||||||||||
| // (verified against config-schema.json on 2026-04-23): | ||||||||||||||||
| // - experimental_thread_store_endpoint | ||||||||||||||||
| // | ||||||||||||||||
| // TOML path: CDX-004 fires for unknown top-level keys. | ||||||||||||||||
| let toml = r#" | ||||||||||||||||
| experimental_thread_store_endpoint = "https://thread-store.example" | ||||||||||||||||
| "#; | ||||||||||||||||
| let diagnostics = validate_config(toml); | ||||||||||||||||
| let unknown: Vec<_> = diagnostics.iter().filter(|d| d.rule == "CDX-004").collect(); | ||||||||||||||||
| assert!( | ||||||||||||||||
| unknown.is_empty(), | ||||||||||||||||
| "experimental_thread_store_endpoint should not trigger CDX-004 (Codex v0.123+), got: {:?}", | ||||||||||||||||
| unknown | ||||||||||||||||
| ); | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| #[test] | ||||||||||||||||
| fn test_codex_v0_123_top_level_keys_accepted_json() { | ||||||||||||||||
| // JSON/YAML path: CDX-CFG-006 fires for unknown top-level keys when | ||||||||||||||||
| // the file is JSON/YAML (NOT TOML, where CDX-004 takes over via | ||||||||||||||||
| // skip_top_level). The fix in rules/codex.rs::KNOWN_CONFIG_TOP_LEVEL_KEYS | ||||||||||||||||
| // must include `experimental_thread_store_endpoint` for CDX-CFG-006 | ||||||||||||||||
| // to accept it. Without that arm of the fix, this test fails even if | ||||||||||||||||
| // the TOML schema allow-list (schemas/codex.rs) is updated. | ||||||||||||||||
| let json = r#"{ | ||||||||||||||||
| "experimental_thread_store_endpoint": "https://thread-store.example" | ||||||||||||||||
| }"#; | ||||||||||||||||
| let diagnostics = validate_config_json(json); | ||||||||||||||||
| let unknown: Vec<_> = diagnostics | ||||||||||||||||
| .iter() | ||||||||||||||||
| .filter(|d| d.rule == "CDX-CFG-006") | ||||||||||||||||
| .collect(); | ||||||||||||||||
| assert!( | ||||||||||||||||
| unknown.is_empty(), | ||||||||||||||||
| "experimental_thread_store_endpoint should not trigger CDX-CFG-006 (Codex v0.123+), got: {:?}", | ||||||||||||||||
| unknown | ||||||||||||||||
| ); | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| #[test] | ||||||||||||||||
| fn test_cdx_cfg_007_danger_full_access_without_ack() { | ||||||||||||||||
| let diagnostics = validate_config("sandbox_mode = \"danger-full-access\""); | ||||||||||||||||
|
|
||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog bullet uses "(#765)", but #765 is the issue being closed; elsewhere in this file the parentheses appear to reference the PR number (e.g., #766, #748, #752). Please update this reference to the actual PR number (or remove the parentheses) to keep the changelog cross-references consistent.