Setup basic route/view/controller for mentee application states #447

JoshDevHub · 2023-12-01T00:00:34Z

What's the change?

Create route, controller action, and view for mentee application states
Link to current mentee application state on applications#index rather than the application itself
Add new model methods for getting future and past states from any given mentee application state
Introduced basic styles to the show page. Text content is spec'd in i18n file

What key workflows are impacted?

Viewing application state for applicants

Highlights / Surprises / Risks / Cleanup

Going to mention some highlights in some review comments

Potential surprise: we're kicking the full styling to a different PR.
Another potential surprise: we currently only have the text content for the application_received state. This is so we can confirm this PR's approach to this is the one we want to go with.

Demo / Screenshots

Issue ticket number and link

Closes #442

Checklist before requesting a review

Please delete items that are not relevant.

Did you add appropriate automated tests?
Have you thought of misfiring code? e.g. too many loops, n+1, or how to handle nils?
Did you leave helpful inline PR comments for the reviewer(s)?
Did you add any relevant tags and decide if this PR is a Draft vs. Ready for Review?

Co-authored-by: Josh Smith <[email protected]>

Co-authored-by: Natblow <[email protected]>

codecov · 2023-12-01T00:02:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06c9b49) 99.26% compared to head (daec3b6) 99.27%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   99.26%   99.27%           
=======================================
  Files         219      220    +1     
  Lines        3393     3437   +44     
=======================================
+ Hits         3368     3412   +44     
  Misses         25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

config/locales/views/user_mentee_applications/mentee_application_states/en.yml

JoshDevHub · 2023-12-01T00:05:04Z

app/models/mentee_application_state.rb

+  end
+
+  def next_state
+    user_mentee_application.mentee_application_states.where('created_at > ?', created_at).order(:created_at).first


These methods could arguably go on the user_mentee_application, but it'd have to accept a parameter for the state. This is one thing I'm not too sure about.

these are fine for now

toyhammered

One change related to the en.yml file.

toyhammered · 2024-01-03T23:15:22Z

app/models/mentee_application_state.rb

+  end
+
+  def next_state
+    user_mentee_application.mentee_application_states.where('created_at > ?', created_at).order(:created_at).first


these are fine for now

config/locales/views/user_mentee_applications/mentee_application_states/en.yml

Co-authored-by: Natblow <[email protected]>

JoshDevHub

Some comments related to the copy we show people at each stage of the process

JoshDevHub · 2024-01-18T19:08:49Z

app/views/user_mentee_applications/mentee_application_states/_coding_challenge.html.erb

+
+<p>You have been sent an email with a coding challenge. This should take you no more than 2-3 hours to complete.</p>
+
+<!-- TODO: fill in more content here -->


Do we want more copy here?

JoshDevHub · 2024-01-18T19:09:42Z

...views/user_mentee_applications/mentee_application_states/_coding_challenge_approved.html.erb

@@ -0,0 +1,3 @@
+<h3>Coding Challenge Approved</h3>
+
+<!-- TODO: do we need this step anymore? It's not outlined in the notion -->


This step is not in the notion outline for this feature. Do we want it?

JoshDevHub · 2024-01-18T19:10:03Z

...views/user_mentee_applications/mentee_application_states/_coding_challenge_received.html.erb

+
+<p>You have submitted your solution to our coding challenge. We will contact you after our team has reviewed your work.</p>
+
+<!-- TODO: fill more content here -->


Does this need any more copy?

JoshDevHub · 2024-01-18T19:10:18Z

app/views/user_mentee_applications/mentee_application_states/_phone_screen_completed.html.erb

@@ -0,0 +1,3 @@
+<h3>Phone Screen Completed</h3>
+
+<!-- This is another status I'm not sure we need? -->


Don't think we need this?

JoshDevHub · 2024-01-18T19:11:10Z

app/views/user_mentee_applications/mentee_application_states/_phone_screen_scheduled.html.erb

@@ -0,0 +1,5 @@
+<h3>Phone Screen</h3>
+
+<p>We would like to schedule a zoom call with you. This call is a quick interview with one of our senior members. It will last about 30 minutes. We will have read your application and reviewed your code. The ideal call is an informal conversation about your goals and your coding journey. There will also be an opportunity for you to ask us questions as well.</p>


Maybe this open with something about how we reviewed their code challenge and liked it?

JoshDevHub · 2024-01-18T19:12:06Z

app/views/user_mentee_applications/mentee_application_states/_withdrawn.html.erb

+
+<p>You have withdrawn your application to the Agency.</p>
+
+<!-- TODO the notion references links? What might those be? -->


Notion references different links that we could give the user here. What did people have in mind for this?

Natblow and others added 6 commits November 22, 2023 17:51

setup logic to get past & future states

a68ec8d

Co-authored-by: Josh Smith <[email protected]>

setup routes, controller, skeleton view

9c79f60

Co-authored-by: Josh Smith <[email protected]>

Add MenteeApplicationState model spec

02dca91

Link to state instead of application on application index

b7fbd02

Co-authored-by: Natblow <[email protected]>

Basic style adjustments on states show page

433a948

Co-authored-by: Natblow <[email protected]>

Add applicant-side text for application_received state

f36b81b

Co-authored-by: Natblow <[email protected]>

JoshDevHub requested a review from toyhammered December 1, 2023 00:00

JoshDevHub commented Dec 1, 2023

View reviewed changes

config/locales/views/user_mentee_applications/mentee_application_states/en.yml Outdated Show resolved Hide resolved

JoshDevHub commented Dec 1, 2023

View reviewed changes

toyhammered requested changes Jan 3, 2024

View reviewed changes

JoshDevHub and others added 5 commits January 17, 2024 12:01

Merge branch 'main' into setup-routes-for-mentee-application-state

f245754

Revert i18n file because switching to partial strategy

f2a9194

Co-authored-by: Natblow <[email protected]>

Rename coding_challenge status key

8c1cb01

Co-authored-by: Natblow <[email protected]>

Reimplement application received content as a partial

f36ee74

Co-authored-by: Natblow <[email protected]>

Add partials for each state of the application process

daec3b6

JoshDevHub commented Jan 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup basic route/view/controller for mentee application states #447

Setup basic route/view/controller for mentee application states #447

JoshDevHub commented Dec 1, 2023

codecov bot commented Dec 1, 2023 •

edited

Loading

JoshDevHub Dec 1, 2023

toyhammered Jan 3, 2024

toyhammered left a comment

toyhammered Jan 3, 2024

JoshDevHub left a comment

JoshDevHub Jan 18, 2024

JoshDevHub Jan 18, 2024

JoshDevHub Jan 18, 2024

JoshDevHub Jan 18, 2024

JoshDevHub Jan 18, 2024

JoshDevHub Jan 18, 2024


		<p>You have been sent an email with a coding challenge. This should take you no more than 2-3 hours to complete.</p>

		<!-- TODO: fill in more content here -->

		@@ -0,0 +1,3 @@
		<h3>Coding Challenge Approved</h3>

		<!-- TODO: do we need this step anymore? It's not outlined in the notion -->


		<p>You have submitted your solution to our coding challenge. We will contact you after our team has reviewed your work.</p>

		<!-- TODO: fill more content here -->

		@@ -0,0 +1,3 @@
		<h3>Phone Screen Completed</h3>

		<!-- This is another status I'm not sure we need? -->

		@@ -0,0 +1,5 @@
		<h3>Phone Screen</h3>

		<p>We would like to schedule a zoom call with you. This call is a quick interview with one of our senior members. It will last about 30 minutes. We will have read your application and reviewed your code. The ideal call is an informal conversation about your goals and your coding journey. There will also be an opportunity for you to ask us questions as well.</p>


		<p>You have withdrawn your application to the Agency.</p>

		<!-- TODO the notion references links? What might those be? -->

Setup basic route/view/controller for mentee application states #447

Are you sure you want to change the base?

Setup basic route/view/controller for mentee application states #447

Conversation

JoshDevHub commented Dec 1, 2023

What's the change?

What key workflows are impacted?

Highlights / Surprises / Risks / Cleanup

Demo / Screenshots

Issue ticket number and link

Checklist before requesting a review

codecov bot commented Dec 1, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

toyhammered left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshDevHub left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 1, 2023 •

edited

Loading