Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception when creating standup group #424

Merged

Conversation

fpsvogel
Copy link
Contributor

@fpsvogel fpsvogel commented Nov 9, 2023

What's the change?

  • Adds missing keyword arg to a ViewComponent.

What key workflows are impacted?

  • Creating standup groups.

Highlights / Surprises / Risks / Cleanup

N/A

Demo / Screenshots

N/A

Issue ticket number and link

Closes #419

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b0f73) 98.78% compared to head (9615658) 98.79%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   98.78%   98.79%   +0.01%     
==========================================
  Files         210      212       +2     
  Lines        3129     3163      +34     
==========================================
+ Hits         3091     3125      +34     
  Misses         38       38              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toyhammered toyhammered merged commit 6e48f40 into main Nov 10, 2023
3 checks passed
@toyhammered toyhammered deleted the fpsvogel.419-fix-exception-when-creating-new-standup-group branch November 10, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new standup throws unhandled exception
2 participants