-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define displayed categories, functors, natural transformations, adjoints #986
Conversation
@maxsnew can you review this? |
Looks good to me. The only question I have is about the displayed functors: this formulation is for a functor between displayed categories over a functor between different base categories. Would it be any simpler to have a direct definition of displayed functor where the base category is the same, i.e., equivalent to If this code is copied from the 1lab, we also need to license it under AGPL >= 3.0. But if it's just adapted we don't need to. |
Thanks for looking into this to @maxsnew and @jpoiret !
I think we can leave this question to the future. I guess it is something that will be decided by usability.
As we know now, we cannot license things under a GPL here. But in this case, since @ecavallo said it was 'guidance', we should credit the 1lab, but there shouldn't be a licensing issue. |
I don't see any immediate benefit to a dedicated definition for Functor^D over the identity. |
Ok, I'm fine with how it is now and it still checks on latest master -> merging. |
Thanks to 1lab for some guidance.