Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic part of #270 #277

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Cosmetic part of #270 #277

merged 11 commits into from
Feb 16, 2024

Conversation

flupe
Copy link
Contributor

@flupe flupe commented Feb 13, 2024

As discussed in #270, currently trying to first have a separate PR with refactorings and cosmetic changes that don't affect compilation.

@flupe
Copy link
Contributor Author

flupe commented Feb 13, 2024

All tests should pass for all commits, although the CI may take issue building agda2hs for some ghc versions when I switched to RWS.

Copy link
Member

@jespercockx jespercockx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is excellent!

@flupe flupe mentioned this pull request Feb 13, 2024
6 tasks
@omelkonian omelkonian self-requested a review February 13, 2024 18:08
Copy link
Contributor

@omelkonian omelkonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Just a few minor comments, but LGTM overall ;)

.github/workflows/ci.yml Show resolved Hide resolved
src/Agda2Hs/Compile/Types.hs Show resolved Hide resolved
src/Main.hs Show resolved Hide resolved
src/Agda2Hs/Compile.hs Show resolved Hide resolved
src/Agda2Hs/HsUtils.hs Outdated Show resolved Hide resolved
src/Agda2Hs/Compile/Type.hs Outdated Show resolved Hide resolved
src/Agda2Hs/Compile/Type.hs Outdated Show resolved Hide resolved
src/Agda2Hs/Compile/Record.hs Outdated Show resolved Hide resolved
src/Agda2Hs/Compile/Function.hs Show resolved Hide resolved
src/Agda2Hs/Compile/Function.hs Outdated Show resolved Hide resolved
@omelkonian omelkonian merged commit 4e3b9a7 into agda:master Feb 16, 2024
5 checks passed
@jespercockx jespercockx added this to the 1.3 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants