Extra builtins types: Word/Float/Char #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlfNorell
requested changes
Oct 28, 2020
Main.hs
Outdated
| Unit -> special Hs.UnitCon | ||
| Nat -> unqual "Integer" | ||
| Float -> unqual "Double" | ||
| Word64 -> qual "Data.Word" "Word64" |
There was a problem hiding this comment.
Having this qualified isn't very nice in the generated code. You anyway have to import Data.Word even to get the qualified version, so I see no strong reason to not simply use Word64.
There was a problem hiding this comment.
It would be nice if we automatically inserted the necessary imports for built-in types, what do you think?
There was a problem hiding this comment.
Yeah, why not. We are parsing the user imports, so it should be easy enough to check if it's already there. You probably also want to check that you don't have Word64 explicitly imported from another module. For checking whether or not it's used I guess the easiest solution is to traverse the generated Haskell code.
omelkonian
force-pushed
the
extra-builtins-types
branch
from
b7fa196 to
dad724e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new built-in types for
Data.Word.Word64,DoubleandCharwithout any fancy business for adding primitives (one can of course just postulate a function with the same name as the Haskell one).