-
Notifications
You must be signed in to change notification settings - Fork 259
Cleaning up dependencies on Data.Fin and Data.Nat ahead of a first attempt to fix Issue1686
#1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 47 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
385a651
resolves issue #626; begins addressing issue #509
jamesmckinna 0b28fa1
tidied up 'local' properties
jamesmckinna a05d59d
knock-on changes
jamesmckinna 55e8b64
knock-on changes
jamesmckinna eb9e3ee
knock-on changes
jamesmckinna f35c323
more knock-on changes
jamesmckinna 41ae9f0
more knock-on changes
jamesmckinna 2b8fc52
more knock-on changes
jamesmckinna 05fac98
trailing whitespace
jamesmckinna 00e1711
yet more...
jamesmckinna 67fdbe0
Merge branch 'master' of https://github.com/agda/agda-stdlib
jamesmckinna de758c8
first steps in #1686: nonzero for Fin/Vec
jamesmckinna ef99599
more nonzero properties for Fin
jamesmckinna be2144e
whitespace; n-suc i operation for Fin
jamesmckinna 7fa306a
additional property of n-suc i operation for Fin
jamesmckinna 81fc405
removed dependency on Data.Fin.Base
jamesmckinna 3233be9
lightened dependency on Data.Fin.Base
jamesmckinna 1526c50
additional property of ℕ-ℕ operation for Fin
jamesmckinna 7dcdf0a
removed dependency on Data.Fin.Base
jamesmckinna 511e466
added NZhead NZtail
jamesmckinna 762c2ba
removed dependency on Data.Nat.Base
jamesmckinna 1b0d5a1
lightened dependency on Data.Fin.Base
jamesmckinna af5eed6
lightened dependencies on Data.Fin.Base/Properties
jamesmckinna 8d61357
lightened dependencies on Data.Fin.Base
jamesmckinna 1fee862
lightened dependencies on Data.Fin.Base
jamesmckinna 258acea
removed dependency on Data.Fin.Base
jamesmckinna 12ee2b0
added NonZero instances
jamesmckinna b0fcbb7
tidying up import order
jamesmckinna e9b36e8
lightened dependencies on Data.Fin.Base/properties; rmeoved dependenc…
jamesmckinna 2d2f836
removed dependencies on Data.Fin.Base; lightened dependency on Data.N…
jamesmckinna 70caf17
lightened/removed dependencies on Data.Fin.Base/Data.Nat.Base
jamesmckinna 467c2a3
lightened/removed dependencies on Data.Fin.Base/Data.Nat.Base
jamesmckinna 0c10ea2
removed dependencies on Data.Fin.Base
jamesmckinna ebe02a4
removed dependencies on Data.Fin.Base
jamesmckinna 1dfb9a6
lightened dependencies on Data.Fin.Base
jamesmckinna 10e3f9d
lightened dependencies on Data.Fin.Base
jamesmckinna acd8cab
Merge branch 'agda:master' into issue1686
jamesmckinna 6816b88
fixed merge conflicts with current agda/master
jamesmckinna 3494c50
narrowed dependency on Fin
jamesmckinna 12dc629
removed NZ ahead of subsequent PR
jamesmckinna e69f126
narrowed dependency on Fin
jamesmckinna 146e673
removed NZ ahead of subsequent PR
jamesmckinna 3e3182a
fixed typo
jamesmckinna 5493a37
added one function and two new proofs to CHANGELOG
jamesmckinna affbfb1
Merge branch 'agda:master' into issue1686
jamesmckinna 7fd0c9f
Merge branch 'agda:master' into issue1686
jamesmckinna b50bf92
Merge branch 'agda:master' into issue1686
jamesmckinna 0f04826
revert additions to Fin.Base/Properties
jamesmckinna 474e414
Merge branch 'master' of https://github.com/agda/agda-stdlib into iss…
jamesmckinna cd17a2b
Merge branch 'issue1686' of https://github.com/jamesmckinna/agda-stdl…
jamesmckinna f25015f
reverted CHANGELOG
jamesmckinna 3cbf205
reverted tabulate properties
jamesmckinna 490223b
restored line breaks
jamesmckinna 77edef7
restored line breaks
jamesmckinna 284a04e
restored line breaks
jamesmckinna fa7aae0
trimming
jamesmckinna 5ec7c78
Merge branch 'agda:master' into issue1686
jamesmckinna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficult to judge the utility of this without the context that it is being used. Any chance we could keep this and
nℕ-suci<nto the follow up PR?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matthew,
this function is not currently used, but since at various points in the library there are uses of its (grotesque) definitional equivalent
n ∸ suc (toℕ i)I thought it worth lifting out as something in its own right; but admittedly in obscure corners:Data.Fin.Properties.opposite-prop,Data.Fin.Properties.opposite-sucData.List.Properties.lookup-applyDownFrom,Data.List.Properties.lookup-downFromSo very easy to prune this, and its properties, back. But it is an example of a 'naturally'-occurring homogeneously-telescoped function on
Fin n, so in the spirit of this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, in which case could you make use of it in this PR to simplify the code that you mention?
My deepest apologies if this was previously in this PR before and you have to add it back in. I'm just playing the part of Goldilocks. Previously the PR was too big to review, but now it contains too small in that it contains this partial change that doesn't stand on its own. In general, we tend to like each PR to stand on its own as people (including me!) promise to do things, but don't actually come back and do it! Not implying that you will, but as a general rule these things happen! Therefore we like each PR to be an obvious standalone improvement over the existing code. Adding a function that is never used doesn't quite pass this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! No, it wasn't, more that I had been laying the groundwork for it... much as I had been enriching the imports of Data.Nat with NonZero and pred.
But you make a good point. When I reinstate it, I'll also use it! Or did you want this to happen now, as opposed to later as part of the whole head/head' etc. enrichment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mind, happy either way. Whichever you'd prefer!