Re-organisation of algebra operation definitions #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was trying to fit ring exponentiation into the new library design for auxiliary definitions over different types of algebraic bundles (multiplication/summation/divisibility etc.), finishing off the reorganisation started in #1351 and #1377. However, it turns out that the design isn't general enough as solvers need access to the operation even when they don't have access to the accompanying ring axioms. Hence this reorganisation:
A new set of modules
Algebra.Definitions.(RawMagma/RawMonoid/RawSemiring)each now contain all the auxiliary definitions that can be defined for the corresponding raw bundle. This gets rid of theAlgebra.PrimalityandAlgebra.Divisibilitymodules.The modules
Algebra.Properties.(Magma/Semigroup/Monoid/Semiring).(Multiplication/Summation/Divisibility)now each re-export the relevant auxiliary definition and contain the properties about it for each bundle respectively.This should provide enough flexibility to add more theory about algebraic structures in future.
This PR doesn't yet deprecate
Algebra.Operations.Ring.