Repository navigation
fix: stage deleted files with libgit2 - #684
Merged
Merged
Conversation
mvanhorn
force-pushed
the
fix/638-stage-deleted-files
branch
from
September 3, 2026 17:08
ffce34b to
1ea9fdb
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the existing
stage_fileprimitive to distinguish a path that still exists in the repository worktree from a tracked path that has been removed. Continue using the current index add operation for present files, but remove an absent tracked path from the index before performing the existing index write so the deletion becomes staged. When a reviewed, tracked file has been removed from the working tree,:stagereaches the libgit2 staging adapter and fails because that adapter unconditionally asks the index to add the missing path. The Git CLI backend already handles this case throughgit add -- <path>, so the defect is specific to the default libgit2 backend.A tracked and committed file is deleted from the worktree, then staged through the libgit2 primitive: the call succeeds and the file is absent from the index relative to
HEAD, representing a staged deletion; An existing new or modified file is staged: the current add-to-index behavior continues to succeed and the path remains present in the index.Fixes #638
AI was used for assistance.