Skip to content

Add settings to skip PR checks and conversation comments - #584

Merged
agavra merged 7 commits into
agavra:mainfrom
antonio2368:feature/show-pr-checks-setting
Aug 13, 2026
Merged

agavra merged 7 commits into
agavra:mainfrom
antonio2368:feature/show-pr-checks-setting

Conversation

@antonio2368

@antonio2368 antonio2368 commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Adds show_pr_checks and show_pr_comments config options, both enabled by default.
Set either to false to avoid fetching and rendering large GitHub check rollups or PR conversation comments. This improves responsiveness for PRs with large CI output or large comments.

We have a lot of checks and a lot of comments generated by our bots which can be fairly large. This led to quite unresponsive experience when reviewing certain PRs 😢

@antonio2368
antonio2368 force-pushed the feature/show-pr-checks-setting branch from d32b61f to 5320bdb Compare August 10, 2026 09:12
Comment thread src/forge/github/gh.rs Outdated
default_repository,
runner,
local_checkout: None,
show_pr_checks: true,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever need pr checks? We can consider just defaulting this to false

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a need for them in a tool like this.
Should we disable it then?

@antonio2368
antonio2368 requested a review from agavra August 13, 2026 09:54
@agavra

agavra commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution @antonio2368 🙏

@agavra
agavra enabled auto-merge (squash) August 13, 2026 17:58
@agavra
agavra disabled auto-merge August 13, 2026 17:58
@agavra
agavra merged commit bd1ab1f into agavra:main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants