Skip to content

Make long errors fully accessible - #511

Merged
agavra merged 4 commits into
agavra:mainfrom
barlevalon:fix/long-error-visibility
Aug 13, 2026
Merged

agavra merged 4 commits into
agavra:mainfrom
barlevalon:fix/long-error-visibility

Conversation

@barlevalon

@barlevalon barlevalon commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • keep status messages to one row and advertise :messages for errors
  • show the complete current error in a full-screen, scrollable Messages view
  • restore the originating diff or target-selector context on close
  • promote PR-list failures to the shared error surface without dropping API response details
  • handle keyboard and mouse scrolling, message replacement, terminal resizing, and Unicode display widths

:messages shows the current full error. Close it with q or Esc; navigation uses the existing help scrolling keys (j/k, arrows, Ctrl-d/u, g/G, Page Up/Down).

Validation

  • cargo fmt --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test — 1151 passed, 1 ignored
  • cargo build
  • git diff --check
  • manually dogfooded at 70×16 with an oversized synthetic forge error, including full-screen rendering, selector return, and mouse/keyboard scrolling

@agavra

agavra commented Jul 30, 2026

Copy link
Copy Markdown
Owner

I've long wanted a feature like this, thanks @barlevalon 🙏 what do you think about making it a full screen thing instead of a popup/modal? it feels a bit distracting to have it that way. Then we can eventually add things like message number/timestamps/etc.. and make it a bit more of a log (which we should probably spool it to as well, but we can do that in the future)

@barlevalon

barlevalon commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks! I like that direction. It fits :messages better and leaves a cleaner path toward a proper message log. I’ll change the current single-message view to full-screen while keeping history, timestamps, and spooling out of scope for this PR. q/Esc will still return to the originating view.

@barlevalon

Copy link
Copy Markdown
Contributor Author

Updated in ef0c18e: :messages now opens a full-screen Messages view rather than a popup. The originating diff/selector view is restored on q/Esc; history, timestamps, and spooling remain intentionally out of scope.

@rickgonzalez

Copy link
Copy Markdown

I chose this public PR to scan for my testing at Lenzon, I hope it's useful in some way:
https://www.lenzon.ai/viewer/cms84dh1r000dtexxsu8mhf13?voice=google-chirp3

@agavra
agavra merged commit b1ea00a into agavra:main Aug 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants