Added multiple space rule#7
Merged
Merged
Conversation
jreidinger
approved these changes
Nov 21, 2025
1 task
lslezak
added a commit
to agama-project/agama
that referenced
this pull request
Dec 2, 2025
## Problem - Some translatable texts in Agama contain indentation spaces, like [here](https://github.com/agama-project/agama/blob/87a04f1769e5d83439f7b1298fc486908ef511da/web/src/components/storage/EncryptionSection.tsx#L50-L51). Example: ```js { { { const message = _("Some very long message \ which spans across multiple lines."); } } } ``` The problem is that the indentation on the second line is actually included in the message text. The HTML collapses multiple spaces to a single space when rendered in a browser so in the end it is not a visible problem for users. But it still might be confusing for the translators. - See related agama-project/eslint-plugin-agama-i18n#7 ## Solution - Enable eslint check - Fix the reported problems ## TODO - [ ] Manually fix the translations in Weblate using `sed` to avoid invalidating the existing translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Example:
The problem is that the indentation on the second line is actually included in the message text. The HTML collapses multiple spaces to a single space when rendered in a browser so in the end it is not a visible problem for users.
But it might be confusing for the translators, they will see text "Some very long message which spans across multiple lines." to translate and they might be wondering if the the extra space characters need to be kept or not. I got this question on the IRC channel.
Let's add a new check to avoid this kind of problems.