Skip to content

[web] Make search of selectors case-insensitive#900

Merged
dgdavid merged 1 commit intomasterfrom
fix-listsearch
Dec 1, 2023
Merged

[web] Make search of selectors case-insensitive#900
dgdavid merged 1 commit intomasterfrom
fix-listsearch

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Dec 1, 2023

Problem

Search introduced in #881 is pseudo case-sensitve by mistake, which results in a not consistent filtering.

Filtering language by "es_ES" Filtering languages by "es_es"
Screen Shot 2023-12-01 at 08 23 11 Screen Shot 2023-12-01 at 08 23 16

Solution

Make search fully case-insentitive.

Testing

  • Adapted unit test
  • Tested manually

Screenshots

Before After
Screen Shot 2023-12-01 at 08 23 11 Screen Shot 2023-12-01 at 08 22 57

@coveralls
Copy link

Coverage Status

coverage: 75.344% (+0.003%) from 75.341%
when pulling 9497aae on fix-listsearch
into 04fa42e on master.

@joseivanlopez joseivanlopez mentioned this pull request Dec 1, 2023
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 3beaef4 into master Dec 1, 2023
@dgdavid dgdavid deleted the fix-listsearch branch December 1, 2023 10:01
@imobachgs imobachgs mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments