Skip to content

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Dec 1, 2023

Problem

YaST is rewriting the timezone settings. See #903.

Solution

  • Write the locale settings on a single call.
  • Mock the InstFunctions module to avoid loading some code when asking whether the second stage will be executed (no second stage in Agama). This code ended up writing the timezone with the wrong value.

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Dec 1, 2023

Coverage Status

coverage: 75.35% (+0.006%) from 75.344%
when pulling 6ebe3ba on force-timezone
into c34f5c7 on master.

dgdavid

This comment was marked as outdated.

@imobachgs
Copy link
Contributor Author

After some tests, the real problem seems to be that YaST is overwriting the localtime. I need to rethink the solution.

@imobachgs imobachgs marked this pull request as draft December 1, 2023 11:20
@imobachgs imobachgs force-pushed the force-timezone branch 2 times, most recently from c6bbbf4 to 204d48f Compare December 2, 2023 17:19
@imobachgs imobachgs marked this pull request as ready for review December 2, 2023 17:59
@imobachgs imobachgs requested a review from dgdavid December 2, 2023 17:59
@imobachgs imobachgs marked this pull request as draft December 2, 2023 18:03
@imobachgs imobachgs marked this pull request as ready for review December 3, 2023 15:55
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the code looks good. So, if you've tested that it works... Just go ahead!

@imobachgs imobachgs merged commit e953702 into master Dec 3, 2023
@imobachgs imobachgs deleted the force-timezone branch December 3, 2023 17:08
@imobachgs imobachgs mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants