[web] Update dependencies (2023-11-14)#866
Merged
Conversation
It was added because of cockpit-starter-kit[1] but they already dropped it[2] because > starter-kit does not use it directly, and none of our derived projects > have it. Thus, in principle it does not make sense to keep it as Agama dependency. As weird side-effect, a few test were fixed to "waitFor" the expeced content. [1] 55c75c3 [2] cockpit-project/starter-kit@67c1c06
It[1] was added more than a year ago[2] in the context of "Adapt React components to the Starter Kit". But probably is no longer needed since async functions, ES6 generators, and `yield` JavaScript operator have broad support among major browsers. [1] https://github.com/facebook/regenerator [2] 55c75c3
It was there because cockpit-starter-kit, which dropped it a year ago[1][2] [1] cockpit-project/starter-kit#590 [2] cockpit-project/starter-kit@6e1fd84
Which came from cockpit-starter-kit. It was dropped there few months ago, in Jun 2023[1] [1] cockpit-project/starter-kit@1e46595
For waiting for the expected content
Remove a leftover it.only and make examples wait a bit for the expected content.
dgdavid
changed the title
imobachgs
approved these changes
Nov 15, 2023
For waiting a bit to find the expected content
Contributor
Author
|
Now CI is failing, but I'm going ahead merging this because running
works locally. So, I'm assuming it is a temporary problem in CI. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another boring PR for keeping dependencies up-to-date via
npm updateandnpm install @package/name@latest. No more--lockfile-version 2because OBS already supports version 3 as we realized at #843Please, note that this time we manage to get rid of some dependencies which were there because cockpit-starter-kit (see #127) but actually not needed anymore. In fact, they are no longer dependencies of starter-kit. Namely,
Apart from these, regenerator-runtime was dropped too because
Note for reviewers: Even though it looks like everything works as expected, please give a try on your development environment and, if possible, different browsers before approving it.