[web] Remove Popup#aria-hidden patch added in #580#801
Merged
Conversation
It's no longer needed in PatternFly React >= 5.1.1 which merged the patch sent. Read more: * patternfly/patternfly-react#9110 * patternfly/patternfly-react#9096 * https://github.com/patternfly/patternfly-react/releases/tag/v5.1.1
dgdavid
force-pushed
the
remove-aria-hidden-patch
branch
from
336408d to
d5a1566
Compare
imobachgs
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We introduced a workaround for a problem with
aria-hiddensiblings when directly unmounting aPF/Modal. Read more in #580 and following below links.aria-hiddenfrom siblings when unmounting the component (v5) patternfly/patternfly-react#9110aria-hiddenfrom siblings when unmounting the component patternfly/patternfly-react#9096But PatternFly React 5.1.1 has included the patch sent a few months ago.
Solution
Drop our workaround now that Agama is using PatternflyReact 5.1.1
Testing
Unit tests passed successfully.