Adapt rust storage client#748
Merged
joseivanlopez merged 10 commits intoagama-project:masterfrom Sep 19, 2023
Merged
Conversation
joseivanlopez
force-pushed
the
adapt-rust-storage
branch
from
feb639d to
626a174
Compare
- Bonus: make lvm and encryption password configurable.
- Manager service was automatically probing when the product changed signal was emitted. - But the selection of a new product should be as atomic as possible. Otherwise, other services (e.g., storage) could start dispatching actions before Manager starts the probing. - And it is not easy for clients to know when Manager has finished with all the actions for configuring the new selected product. - Now, after selecting a product, Manager does not probed anymore. Clients have to explicitly request a probe action in order to configure everything according to the new selected product (i.e., storage and software config).
joseivanlopez
force-pushed
the
adapt-rust-storage
branch
from
18cb718 to
9a760f6
Compare
imobachgs
approved these changes
Sep 19, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
LGTM. Just a minor typo. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The target disk for installation (boot device) is not selected when loading a profile:
See #745.
Solution
The Agama CLI was adapted to support the new storage settings (#738). Now the profile can contain
bootDevice,lvmandencryptionPasswordoptions in thestoragesection:Note: The behavior of the Manager service was mofidied to avoid some issues after selecting a new product. Now on, clients have to explicitly call to
Manager#Probe.Testing