Add support to assign an interface or match settings to a connection

[teclator]

Problem

Agama allows to add/update network connections. However, it relies on NetworkManager to decide which interface to use. Alternatively, Agama should allow the user to assign a connection to an specific interface.

Instead of using just an interface name, Agama should offer some matching capabilities, just like NetworkManager. How the API should look like is up to who implements the feature but the interface-name, the path and the driver should be supported.

• https://trello.com/c/H2ISHKvi/3395-2-agama-allow-assigning-a-network-configuration-to-an-specific-interface

Solution

It has been added support to specify to which interfaces the connection should be bond to supporting it directly through the interface name attribute or through a set of match settings as them are supported by NetworkManager.

"network": {
    "connections": [
      {
        "id": "Ethernet network device 1",
        "method": "manual",
        "interface": "eth0",
        "addresses": [
          "192.168.122.100/24"
        ],
        "gateway": "192.168.122.1",
        "nameservers": [
          "192.168.122.1"
        ]
      }
    ]
  }

Testing

• Added a new unit test
• Tested manually

[coveralls]

coverage: 72.814% (-0.05%) from 72.863% when pulling c3f1bd9 on matching_settings into 9c310af on master.

[imobachgs]

In general, it looks good. Just a few suggestions.

[imobachgs]

You can do:

    HashMap::from([
        ("driver", drivers),
        ("kernel-command-line", kernels),
        ("path", paths),
        ("interface-name", interfaces),
    ])

It looks more readable to me and it is easy to find out what is included in the HashMap.

[teclator]

Yep, originally did so, then added some logic to inserting only the key if it was not empty but as we are inserting it always now it makes sense to do so. Thanks