Form now scrolls up if warning is shown#699
Merged
imobachgs merged 3 commits intoagama-project:masterfrom Aug 12, 2023
Merged
Conversation
Closed
imobachgs
requested changes
Aug 11, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Thanks @balsa-asanovic! The change looks good. Please, add an entry to the changes file that includes a reference to the bug (gh##468).
Contributor
Author
|
@imobachgs added entry to the changes file. |
imobachgs
reviewed
Aug 12, 2023
imobachgs
approved these changes
Aug 12, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Thanks! LGTM. I will merge as soon as the tests run.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Forms generally show errors on top, so when the submit is clicked again if the error is shown again, it seems as if nothing happens.
fixes #468
Solution
I've attached a useRef hook to the alert and whenever the component is rendered with the error it will scroll up to it.
Testing
No unit test for this component.
Tested manually.
Screenshots