Skip to content

Run the Rubocop CI check only when a Ruby file is changed#694

Merged
lslezak merged 2 commits intomasterfrom
ci-rubocop
Aug 9, 2023
Merged

Run the Rubocop CI check only when a Ruby file is changed#694
lslezak merged 2 commits intomasterfrom
ci-rubocop

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented Aug 9, 2023

Problem

  • The Rubocop check is run always, even when no Ruby file is modified
  • This makes CI slower and wastes some server resources

Solution

  • Put the Rubocop job into a separate file and use the path specifiers so it is run only when a matching file is updated

This avoids running Rubocop when it is not needed
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 9, 2023

Coverage Status

coverage: 72.134%. remained the same when pulling 766f3dd on ci-rubocop into 4df4c55 on master.

@lslezak lslezak merged commit e9bff87 into master Aug 9, 2023
@lslezak lslezak deleted the ci-rubocop branch August 9, 2023 10:55
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants