Revert "Use html-webpack-plugin for minifying HTML in production"

[lslezak]

Problem

The Agama installer displays an empty screen and the browser log contains errors like:

Uncaught TypeError: Cannot read properties of null (reading 'children')
Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Especially this error is strange:

Uncaught Error: React Refresh runtime should not be included in the production bundle.

According to out Webpack configuration that react-refresh plugin should be included only in the development mode, not in production. 🤔

Solution

It turned out that the problem is caused by using the html-webpack-plugin which somehow conflicts with the react-refresh plugin. When it is enabled the production build contains this in the index.html file:

<script defer="defer" src="reactRefreshSetup.js">

After reverting #680 it works fine.

That's quite strange, I did several tests with the html-webpack-plugin plugin and it worked fine, I'm not sure what I did wrong/differently... 😳

Replacement

I found the html-minimizer-webpack-plugin, I'll try it later, maybe it works better...

[coveralls]

coverage: 72.203%. remained the same when pulling 70c7bd2 on revert_html-webpack-plugin into 050ed9d on master.

[ancorgs]

LGTM. Let's go for the revert while we find something better.

[imobachgs]

Thanks for finding the issue!