Conversation
imobachgs
approved these changes
Jul 31, 2023
mvidner
reviewed
Jul 31, 2023
| <!-- | ||
| The Cockpit server returns "po.<LANG>.js" content for the "po.js" request, | ||
| the requested language is obtained from the "CockpitLang" cookie sent in | ||
| the HTTP header. For missing translations it returns an empty string. |
Contributor
There was a problem hiding this comment.
For missing translations it returns an empty string.
Does this mean that if I miss to translate some strings, there will be empty texts?
Suggested change
| the HTTP header. For missing translations it returns an empty string. | |
| the HTTP header. For missing translations it returns an empty script. |
This was referenced Jul 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
po.jsfile with translationsNotes
deferattribute is needed because the JS modules (index.js) are deferred by default. We need to defer also loading the localization code otherwise callingcockpit.locale()insidepo.jswould fail because it would not be defined yet. Thecockpit.jsfile is bundled in theindex.jsfile so that file needs to be loaded before the translations.Testing
/cockpit/@localhost/shell/index.htmlpathSessionmenu in the top right corner, select theDisplay languageoptiončeština(Czech)/or click theAgamalabel in the left side barDiagnostic tools->Show Log. So far there are just few translations to test, see the web/po/cs.po file.Zavříttranslation for theClosebuttonScreenshots
The "Close" button with the Czech translation activated