Apply suggestions from Clippy#662
Merged
imobachgs merged 2 commits intoagama-project:masterfrom Jul 13, 2023
imobachgs:clippy
Merged
Apply suggestions from Clippy#662imobachgs merged 2 commits intoagama-project:masterfrom imobachgs:clippy
imobachgs merged 2 commits intoagama-project:masterfrom
imobachgs:clippy
Conversation
mvidner
approved these changes
Jul 13, 2023
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Thanks!
For the newbies like me: call it like cargo clippy
| mapping | ||
| .get(&tzp.to_string()) | ||
| .expect(format!("Unknown timezone part {tzp}").as_str()) | ||
| .unwrap_or_else(|| panic!("Unknown timezone part {tzp}")) |
Contributor
There was a problem hiding this comment.
JFYI: I liked the original more so I ran clippy and found the reason for the change: the format! would always be called.
Contributor
Author
There was a problem hiding this comment.
Yes, same with me. :)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the beginning of the project, we have not paid enough attention to Clippy's suggestions. This PR applies most of them
However, some of them are still pending: