-
Notifications
You must be signed in to change notification settings - Fork 81
New storage proposal settings #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 56 commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
e93e79e
Remove dead code
ancorgs bf8a1c8
WIP: very preliminary steps to ProposalSettings
ancorgs ed138ce
WIP: draft for VolumeOutline (instead of templates)
ancorgs 93cd4b1
WIP: D-Bus conversions
joseivanlopez c3ac9e8
WIP: draft for getting the volume template for a path
ancorgs 11baf61
WIP: D-Bus conversions
joseivanlopez 69c3984
WIP: use VolumeTemplatesBuilder
joseivanlopez ff69860
WIP: adapt proposal backend
joseivanlopez aad83cb
WIP: add ProposalSettingsReader
joseivanlopez d015f34
WIP: Add system_vg_devices
joseivanlopez 88c3309
WIP: to_y2storage conversion
joseivanlopez f2ad77b
WIP: add missing dbus data
joseivanlopez 32c8090
WIP: remove format_options
joseivanlopez b233c4c
WIP: minor corrections and a temporary test
ancorgs 88e986a
WIP: some improvements
joseivanlopez 102ab2d
WIP: conversion from y2storage
joseivanlopez 23bac3e
WIP: some fixes
joseivanlopez cf4e693
WIP: doc code and small fixes
joseivanlopez 7dc224e
WIP: Rubocop
joseivanlopez 9b3a7e0
WIP: Rubocop
joseivanlopez 86b9ef1
Several small fixes
ancorgs 6469521
WIP: reorganizing tests and adding temporary fixes
ancorgs 2f41a60
WIP: more small adaptations
ancorgs 035f4f0
WIP: some fixes
joseivanlopez bdd1c1a
Tests for conversions to D-Bus
joseivanlopez aca34ed
Test settings conversion from D-Bus
joseivanlopez 228fc06
WIP: Test volume conversion from D-Bus
joseivanlopez c57edd2
Update tests for DBus::Storage::Manager and add fixes
ancorgs f669169
Small modification to the Storage::Manager test
ancorgs 9dd41da
WIP: more tests adaptations and small fixes
ancorgs 02fa693
Rubocop adjustments
ancorgs 5db39de
Fix conversions
joseivanlopez b28d423
Code style
joseivanlopez 5149822
Relocate tests and minor fixes
joseivanlopez c042cbc
Fix yardoc
joseivanlopez 389bf34
ToY2Storage tests and some fixes
joseivanlopez 9ede962
More tests and fixes
joseivanlopez 9c3b6cb
Several fixes
joseivanlopez 87d69cf
Tests for volume conversion from Y2Storage
joseivanlopez eab41d8
Small conversion fix
joseivanlopez 2959194
More conversion tests
joseivanlopez cb3d031
Rewrite proposal tests
joseivanlopez dd9b027
Add D-Bus attribute to get the product mount points
joseivanlopez b1655bc
Add D-Bus tests
joseivanlopez 049f2a9
Avoid unknown space policies
joseivanlopez a81c12f
Tests for proposal settings reader
joseivanlopez effeb2a
Some tests for VolumeTemplatsBuilder
ancorgs 6d2ea9a
Add missing mocking
joseivanlopez b3dfa69
Merge branch 'master' into plane
joseivanlopez 5fcb1cb
Do not memoize volume templates builder
joseivanlopez a5c37ba
Adapt storage section of config file
joseivanlopez 4f7cd3b
Complete and fix the config file
joseivanlopez d814b5d
Update D-Bus documentation
joseivanlopez 1d1b5d5
Fix D-Bus method name
joseivanlopez d0b9db3
doc/dbus: each documented interface goes to a separate .doc.xml file
mvidner f35db4b
Copy proxy config to the target system
teclator 2e4dcad
Read the current proxy configuration
teclator 1786301
Make install method public
teclator 3a89c89
Added ProxySetup#install unit test
teclator 7ea9c0f
Ensure the read is done out of the chroot
teclator b92528e
Add the needed packages before installing the software
teclator bab9875
Move the proxy propose before software proposal is done
teclator 6821ba2
Logger fix and more unit tests
teclator 1b91c24
Enable service in target
teclator 393e021
Added changelog
teclator f992c17
Merge pull request #711 from openSUSE/proxy_install
teclator ed12545
weblate-merge-po.yml - fixed PO file validation
lslezak 4ad4cd2
Merge pull request #716 from openSUSE/po_validation_fix
lslezak 82080ec
Update PO files
yast-bot 3e8707e
Fix the connect() function error
imobachgs 6d855b2
Make NetworkSystem generic over the Adapter
imobachgs ea6cf3b
Allow to inject a different adapter in the NetworkSystem
imobachgs 2835ca5
Write agama-dbus-server integration tests
imobachgs 8f8c5d0
Document a potential bug in the network service
imobachgs 00840d1
Fix NetworkClient to wait for the connection to appear
imobachgs 85ec299
Use a signal to detect when a connection is added
imobachgs c55edcf
Merge pull request #717 from openSUSE/po_merge_5999537439
lslezak f22a960
Tests: detect when a service is started
imobachgs c867656
Run "cargo fmt" happy according to the CI
imobachgs 4dd1ad0
Remove commented (and outdated) code
imobachgs 601135f
Update from code review
imobachgs e6aff50
Merge pull request #718 from imobachgs/tests
imobachgs 4fa3e39
Mark more texts for translation
lslezak a7ce2eb
Remove product counter
lslezak 4322aa1
fix wrong name in rake install
jreidinger 6097959
Merge pull request #720 from openSUSE/fix_rake_install
jreidinger dbad5f9
Merge pull request #719 from openSUSE/add_more_translations
lslezak 67d9a72
Improvements from review
joseivanlopez cbb6811
Fix some typos
joseivanlopez 7bd1869
Sort requires
joseivanlopez c9bde61
Make code easier to understand
joseivanlopez 2205da8
Merge branch 'master' into plane
joseivanlopez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
doc/dbus/bus/org.opensuse.Agama.Storage1.Proposal.Calculator.bus.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| org.opensuse.Agama.Storage1.bus.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <node name="/org/opensuse/Agama/Storage1/Proposal"> | ||
| <interface name="org.freedesktop.DBus.Introspectable"> | ||
| <method name="Introspect"> | ||
| <arg name="xml_data" direction="out" type="s"/> | ||
| </method> | ||
| </interface> | ||
| <interface name="org.freedesktop.DBus.Properties"> | ||
| <method name="Get"> | ||
| <arg name="interface_name" direction="in" type="s"/> | ||
| <arg name="property_name" direction="in" type="s"/> | ||
| <arg name="value" direction="out" type="v"/> | ||
| </method> | ||
| <method name="Set"> | ||
| <arg name="interface_name" direction="in" type="s"/> | ||
| <arg name="property_name" direction="in" type="s"/> | ||
| <arg name="val" direction="in" type="v"/> | ||
| </method> | ||
| <method name="GetAll"> | ||
| <arg name="interface_name" direction="in" type="s"/> | ||
| <arg name="value" direction="out" type="a{sv}"/> | ||
| </method> | ||
| <signal name="PropertiesChanged"> | ||
| <arg name="interface" type="s"/> | ||
| <arg name="changed_properties" type="a{sv}"/> | ||
| <arg name="invalidated_properties" type="as"/> | ||
| </signal> | ||
| </interface> | ||
| <interface name="org.opensuse.Agama.Storage1.Proposal"> | ||
| <property type="s" name="BootDevice" access="read"/> | ||
| <property type="b" name="LVM" access="read"/> | ||
| <property type="aas" name="SystemVGDevices" access="read"/> | ||
| <property type="s" name="EncryptionPassword" access="read"/> | ||
| <property type="s" name="EncryptionMethod" access="read"/> | ||
| <property type="s" name="EncryptionPBKDFunction" access="read"/> | ||
| <property type="s" name="SpacePolicy" access="read"/> | ||
| <property type="aa{sv}" name="Volumes" access="read"/> | ||
| <property type="aa{sv}" name="Actions" access="read"/> | ||
| </interface> | ||
| </node> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
doc/dbus/org.opensuse.Agama.Storage1.Proposal.Calculator.doc.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN" | ||
| "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd"> | ||
| <node name="/org/opensuse/Agama/Storage1"> | ||
| <node name="zfcp_controllers" /> | ||
| <node name="zfcp_disks" /> | ||
| <!-- | ||
| Interface for calculating a new storage proposal. | ||
| --> | ||
| <interface name="org.opensuse.Agama.Storage1.Proposal.Calculator"> | ||
| <!-- | ||
| Gets the default values for a volume with the given mount path. | ||
| --> | ||
| <method name="DefaultVolume"> | ||
| <!-- | ||
| E.g., /home | ||
| --> | ||
| <arg name="mount_path" direction="in" type="s"/> | ||
| <!-- | ||
| MountPath s | ||
| MountOptions as | ||
| TargetDevice s | ||
| TargetVG s | ||
| FsType s | ||
| MinSize t (bytes) | ||
| MaxSize t (bytes. Optinal, max size is considered as unlimited if omitted) | ||
| AutoSize b | ||
| Snapshots b | ||
| Outline a{sv} | ||
| Required b | ||
| FsTypes as | ||
| SupportAutoSize b | ||
| SnapshotsConfigurable b | ||
| SnapshotsAffectSizes b | ||
| SizeRelevantVolumes as | ||
| --> | ||
| <arg name="volume" direction="out" type="a{sv}"/> | ||
| </method> | ||
| <!-- | ||
| Calculates a new proposal. | ||
| --> | ||
| <method name="Calculate"> | ||
| <!-- | ||
| BootDevice s | ||
| LVM b | ||
| SystemVGDevices as | ||
| EncryptionPassword s | ||
| EncryptionMethod s | ||
| EncryptionPBKDFunction s | ||
| SpacePolicy s | ||
| SpaceActions a{ss} | ||
| Volumes aa{sv} | ||
| List of volumes to create. The values for each volume are the same as the values returned | ||
| by DefaultVolume method. The Outline (if given) would be ignored. | ||
| --> | ||
| <arg name="settings" direction="in" type="a{sv}"/> | ||
| <arg name="result" direction="out" type="u"/> | ||
| </method> | ||
| <property type="ao" name="AvailableDevices" access="read"/> | ||
| <!-- | ||
| Relevant mount points for the selected product. Normally, the product defines some specific | ||
| values for these mount points (e.g., min and max sizes, file system type, etc). | ||
| --> | ||
| <property type="as" name="ProductMountPoints" access="read"/> | ||
| <property type="o" name="Result" access="read"/> | ||
| </interface> | ||
|
|
||
| </node> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <node name="/org/opensuse/Agama/Storage1/Proposal"> | ||
| <!-- | ||
| Interfaces with the properties of the calculated proposal. | ||
| --> | ||
| <interface name="org.opensuse.Agama.Storage1.Proposal"> | ||
| <property type="s" name="BootDevice" access="read"/> | ||
| <property type="b" name="LVM" access="read"/> | ||
| <property type="aas" name="SystemVGDevices" access="read"/> | ||
| <property type="s" name="EncryptionPassword" access="read"/> | ||
| <property type="s" name="EncryptionMethod" access="read"/> | ||
| <property type="s" name="EncryptionPBKDFunction" access="read"/> | ||
| <property type="s" name="SpacePolicy" access="read"/> | ||
| <!-- | ||
| List of volumes used for calculating the proposal. | ||
| Each volume has the following properties: | ||
| MountPath s | ||
| MountOptions as | ||
| TargetDevice s | ||
| TargetVG s | ||
| FsType s | ||
| MinSize t (bytes) | ||
| MaxSize t (bytes. Optinal, max size is considered as unlimited if omitted) | ||
|
joseivanlopez marked this conversation as resolved.
Outdated
|
||
| AutoSize b | ||
| Snapshots b | ||
| Outline a{sv} | ||
| Required b | ||
| FsTypes as | ||
| SupportAutoSize b | ||
| SnapshotsConfigurable b | ||
| SnapshotsAffectSizes b | ||
| SizeRelevantVolumes as | ||
| --> | ||
| <property type="aa{sv}" name="Volumes" access="read"/> | ||
| <!-- | ||
| Actions to perform in the system in order to create the volumes. | ||
| Each action has the following properties: | ||
| Text s | ||
| Subvol b | ||
| Delete b | ||
| --> | ||
| <property type="aa{sv}" name="Actions" access="read"/> | ||
| </interface> | ||
| </node> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.