Skip to content

CLI: Better progress reporting#653

Merged
imobachgs merged 4 commits intoagama-project:masterfrom
imobachgs:better-progress
Jul 7, 2023
Merged

CLI: Better progress reporting#653
imobachgs merged 4 commits intoagama-project:masterfrom
imobachgs:better-progress

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Jul 7, 2023

Problem

The progress reporting in the CLI was not exactly user-friendly. It started as an experiment during Hack Week, and we did not have the time to look at it again.

Solution

The work on the progress reporting is not finished but at least this PR is a step in the right (?) direction:

  • Refactoring, simplifying and documenting the code related to progress reporting.
  • Writing a reporting mechanism similar to the one in the web UI (with the same limitations too).

Testing

  • Tested manually

Screenshots

Old progress New progress
Screenshot from 2023-07-07 14-05-10 Screenshot from 2023-07-07 13-48-07

What to do

  • This mechanism might not work that well when retrying an action.
  • Error reporting is still rather poor.
  • The main.rs file deserves some love.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 7, 2023

Coverage Status

coverage: 72.432% (+0.01%) from 72.422% when pulling 0777161 on imobachgs:better-progress into e8be9bb on openSUSE:master.

@imobachgs imobachgs merged commit 1b8479e into agama-project:master Jul 7, 2023
@imobachgs imobachgs deleted the better-progress branch July 10, 2023 07:36
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 20, 2024

Coverage Status

Changes unknown
when pulling 0777161 on imobachgs:better-progress
into ** on openSUSE:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants