Skip to content

CLI: wait before trying to start the installation#651

Merged
imobachgs merged 4 commits intoagama-project:masterfrom
imobachgs:wait-before-install
Jul 6, 2023
Merged

CLI: wait before trying to start the installation#651
imobachgs merged 4 commits intoagama-project:masterfrom
imobachgs:wait-before-install

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Jul 6, 2023

Problem

The agama install command might find the Manager service busy even if the progress reporting has finished. It may start the installation process right before the service status has been updated (although it is effectively not busy).

Solution

Let's try to make the agama install command more robust:

  • Wait until the Manager reports to be idle.
  • Retry (up to three times) if there is a problem.
  • Stop reporting the progress while waiting. This command is expected to be used in the auto-installation scripts. We can add a monitor command for such a purpose.

Notes

  • Error and progress reporting in the UI are far from ideal. But let's address that later.
  • We could add switches to influence the number of retries and the time between them.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 6, 2023

Coverage Status

coverage: 72.396% (-0.1%) from 72.505% when pulling 6d99825 on imobachgs:wait-before-install into f6152b0 on openSUSE:master.

Copy link
Copy Markdown
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 3ad0775 into agama-project:master Jul 6, 2023
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants