Add support for questions with no default options#649
Merged
imobachgs merged 2 commits intoagama-project:masterfrom Jul 6, 2023
imobachgs:questions-optional-default
Merged
Add support for questions with no default options#649imobachgs merged 2 commits intoagama-project:masterfrom imobachgs:questions-optional-default
imobachgs merged 2 commits intoagama-project:masterfrom
imobachgs:questions-optional-default
Conversation
teclator
approved these changes
Jul 6, 2023
Contributor
teclator
left a comment
teclator
left a comment
There was a problem hiding this comment.
LGTM. I tested the patch and it fixes the issue, thanks!! 🥳
Contributor
Author
|
Thanks for testing it! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Questions service crashes if no default options are given. It was supported in the Ruby-based version, so we need to fix the new service to support it.
According to a comment on the code, we should stop using an array for the default options, forcing a default option anyway. But let's discuss that later.