Update the org.opensuse.Agama.Network1 documentation#648
Merged
imobachgs merged 2 commits intoagama-project:masterfrom Jul 4, 2023
imobachgs:update-network-dbus-docs
Merged
Update the org.opensuse.Agama.Network1 documentation#648imobachgs merged 2 commits intoagama-project:masterfrom imobachgs:update-network-dbus-docs
imobachgs merged 2 commits intoagama-project:masterfrom
imobachgs:update-network-dbus-docs
Conversation
joseivanlopez
approved these changes
Jul 4, 2023
Contributor
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
LGTM
I think we have to improve our doc mechanism to avoid repetition. For example, the org.opensuse.Agama.Network1.Connection.Wireless interface is defined 4 times. BTW, maybe we only need the doc/dbus/bus files if no extra info is going to be added.
|
Changes unknown |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the org.opensuse.Agama.Network1 D-Bus service documentation.