Skip to content

CLI: update the network configuration#641

Closed
imobachgs wants to merge 35 commits intomasterfrom
write-network-changes
Closed

CLI: update the network configuration#641
imobachgs wants to merge 35 commits intomasterfrom
write-network-changes

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Jun 29, 2023 •
edited
Loading

⚠️ For some reason, we cannot comment on this PR. It is replaced with #647.

imobachgs added 21 commits June 23, 2023 11:58
@imobachgs
Use the Id to index the network connections
d84b21e
@imobachgs
Add an method to get a connection path by name
ec56b57
@imobachgs
Use ObjectPath structs instead of strings
75283e0
@imobachgs
Prefer ids to UUIDs in the network model
7577639
@imobachgs
Make Clippy happy
070f789
@imobachgs
Implement the merge strategy for NetworkSettings
ec36574
@imobachgs
Fix the Jsonnet example
a7c6609
@imobachgs
Allow not specifying the connection method
d68d6d3
@imobachgs
Do not allow additional attributes in the network settings
1d55105
@imobachgs
Use a vector of strings to set IPv4 'Addresses'
f7604d4
@imobachgs
Move DeviceType to the types module
72bd865
@imobachgs
Use a string to represent an IP method over D-Bus
3c1f8a4
@imobachgs
Write network settings from a profile
24a5efb
@imobachgs
Write wireless settings from a profile
74003d7
@imobachgs
Fix the update of the name servers in NetworkManager
248ebde 
* Do not send the "dns" key as it takes precedence
  over "dns-data".
@imobachgs
Annotate the wireless D-Bus interface's setters
bc0c4d0
@imobachgs
Log unsupported network devices
f3a0d0e
@imobachgs
Add support for duplicated connection IDs
85c2eb3
@imobachgs
Do not expose the connection UUID over D-Bus
80cd754
@imobachgs
Write the network configuration from the CLI
378dacf
@imobachgs
Log errors when writing network connections
c6f25e5
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 29, 2023 •
edited
Loading

Coverage Status

coverage: 72.515% (-0.3%) from 72.829% when pulling e401b66 on write-network-changes into b566243 on master.

@imobachgs imobachgs marked this pull request as ready for review July 4, 2023 11:22
@imobachgs
Copy link
Copy Markdown
Contributor Author

imobachgs commented Jul 4, 2023

For some reason, we cannot comment on this PR. We get an error: "Line must be part of the diff and Diff hunk can't be blank". We have replaced this one with #647.

@imobachgs imobachgs closed this Jul 4, 2023
@imobachgs imobachgs deleted the write-network-changes branch August 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imobachgs @coveralls