Skip to content

Move agama-network into agama-dbus-server#638

Merged
imobachgs merged 2 commits intomasterfrom
move-agama-network
Jun 22, 2023
Merged

Move agama-network into agama-dbus-server#638
imobachgs merged 2 commits intomasterfrom
move-agama-network

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Move the network service, implemented in agama-network, to the agama-dbus-server package. All the code is kept under a new network module.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 22, 2023

Pull Request Test Coverage Report for Build 5345642365

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.83%

Totals Coverage Status
Change from base Build 5345616913: 0.0%
Covered Lines: 5644
Relevant Lines: 7102

💛 - Coveralls

Base automatically changed from refactor-rust to master June 22, 2023 12:38
@imobachgs imobachgs merged commit 9989430 into master Jun 22, 2023
@imobachgs imobachgs deleted the move-agama-network branch June 22, 2023 13:36
Copy link
Copy Markdown
Contributor

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, the agama-network crate is swallowed by the agama-dbus-server crate where it becomes a network module.
We do this because too many packages/crates do not make sense, we don't need them for dependency/governance reasons like other projects do.

@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants