Merged
Conversation
Pull Request Test Coverage Report for Build 5345382518
💛 - Coveralls |
jreidinger
reviewed
Jun 22, 2023
jreidinger
approved these changes
Jun 22, 2023
mvidner
reviewed
Jun 22, 2023
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
I want to understand the genaral meaning of Store, Settings, Client better.
I'll render the docs and look there.
Only Proxy is clear: the API exactly corresponding to D-Bus
Co-authored-by: Martin Vidner <mvidner@suse.cz>
* Currently, the macro cannot be used from another package. * Ideally, settings should live on its own package. * Then we should use something like proc-macro-crate to find the correct name of the Crate.
mvidner
approved these changes
Jun 22, 2023
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Thanks for the description!
Merged
|
Changes unknown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
agama-libpackage is growing with support for more settings and services. This PR proposes to change the approach a bit and organize the code using a different module for each topic (users, storage, etc.). So now we havenetwork,users,softwareandstoragemodules which contain the logic specific to those topics.We introduce this approach in #622 and it seems to work better than the previous one.