Skip to content

Add zFCP to storage client #632

Merged
joseivanlopez merged 3 commits intoagama-project:zfcpfrom
joseivanlopez:storage-client
Jun 20, 2023
Merged

Add zFCP to storage client #632
joseivanlopez merged 3 commits intoagama-project:zfcpfrom
joseivanlopez:storage-client

Conversation

@joseivanlopez
Copy link
Copy Markdown
Contributor

@joseivanlopez joseivanlopez commented Jun 15, 2023

Problem

The storage service already provides a D-Bus API for managing zFCP devices, see #594 and #626. But the cockpit storage client is not adapted yet.

Solution

Adapt the storage client in order to provide the required API for implementing a zFCP UI.

Note: This PR is created through the zfcp feature branch.

Testing

  • Added new unit tests
  • Tested manually

@joseivanlopez joseivanlopez force-pushed the storage-client branch 2 times, most recently from 345ed01 to a2bf77f Compare June 20, 2023 09:13
@joseivanlopez joseivanlopez changed the base branch from master to zfcp June 20, 2023 09:15
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 20, 2023

Pull Request Test Coverage Report for Build 5321093845

  • 75 of 75 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 76.957%

Totals Coverage Status
Change from base Build 5320747321: 0.2%
Covered Lines: 5703
Relevant Lines: 7161

💛 - Coveralls

@joseivanlopez joseivanlopez marked this pull request as ready for review June 20, 2023 09:34
Copy link
Copy Markdown
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit b3f7212 into agama-project:zfcp Jun 20, 2023
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants