Skip to content

Fixed rubygem installation when running in yupdate script#619

Merged
lslezak merged 1 commit intomasterfrom
yupdate_git_fix
Jun 13, 2023
Merged

Fixed rubygem installation when running in yupdate script#619
lslezak merged 1 commit intomasterfrom
yupdate_git_fix

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented Jun 13, 2023

Problem

  • Installation via the yupdate script failed
  • The reason is that we cannot run git command at that point because yupdate downloads only the source tarball without the git history (the .git subdirectory)

Solution

  • Check whether the .git directory exists, if not then use some fixed fake version. For patching a Live ISO system it is not important.

Testing

  • Tested manually, yupdate can now patch the system without problem

@lslezak lslezak merged commit 6ff264b into master Jun 13, 2023
@lslezak lslezak deleted the yupdate_git_fix branch June 13, 2023 13:51
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5256297234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.826%

Totals Coverage Status
Change from base Build 5252695241: 0.0%
Covered Lines: 5626
Relevant Lines: 7080

💛 - Coveralls

@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants