[web] Users: improve the root authentication section#615
Merged
Conversation
Providing more comprehensive information to the user if there is no authentication method for the root user, which may result in a system without administrative access. Once a method is defined, a table listing authentication methods will be displayed instead. This might be changed in a near future for a better alternative.
dgdavid
commented
Jun 12, 2023
Pull Request Test Coverage Report for Build 5244317778
💛 - Coveralls |
dgdavid
commented
Jun 12, 2023
dgdavid
changed the title
dgdavid
force-pushed
the
root-password-empty-state
branch
from
c71583e to
6e49bd9
Compare
Co-Authored-By: José Iván López González <jlopez@suse.com>
For improving the text displayed when no root auth method has been defined yet.
dgdavid
force-pushed
the
root-password-empty-state
branch
from
6e49bd9 to
f3a7770
Compare
jreidinger
approved these changes
Jun 12, 2023
Contributor
jreidinger
left a comment
jreidinger
left a comment
There was a problem hiding this comment.
for me much better now
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current way Agama is rendering the Root Authentication section in the Users page do not make evident that there is no auth method defined, and it's easy to overlook the button for displaying the actions available for each method.
Solution
Provide the user more comprehensive information if there is no authentication method for the root user, which may result in a system without administrative access.
For that, the empty state pattern we already have in the user section is used when there is none auth method defined. Once the user defines one, the table listing auth methods and available actions is displayed. The idea is to go further and do not use a table for rendering methods, but this can be done in later PR.
A slightly related change
Since it's related, this PR also changes the text used in the users overview section when no root auth method has been defined yet.
Click to show/hide before and after screenshots about changed overview text
Testing
Screenshots
Note: screenshots below might have change because minor changes asked during the review, specially in regard to the wording
Before
After