Fix the initialization of the Locale1 service#612
Merged
Conversation
* Keep the connection around so it does not get dropped.
Pull Request Test Coverage Report for Build 5212724549
💛 - Coveralls |
jreidinger
reviewed
Jun 8, 2023
| // When adding more services here, the order might be important. | ||
| crate::questions::start_service(ADDRESS).await?; | ||
| crate::locale::start_service(ADDRESS).await?; | ||
| let _conn = crate::locale::start_service(ADDRESS).await?; |
Contributor
There was a problem hiding this comment.
btw we should document that we need to store connection, otherwise it will drop whole dbus object. So next time we do not remove it :)
Contributor
Author
There was a problem hiding this comment.
Yes, we should document it. Additionally, trying the approach I proposed in the description might help.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until we find a better way, we need to keep the connection around. Otherwise, it will get dropped.
A better solution might be to pass a copy of the connection instead of the address to each service. But, today, let's keep the API as it is.