Merged
Conversation
Also relax the dependency to allow anything < 1.0 On the assumption that its maintainer (myself) will be quick to fix any API problems that may occur on version upgrades.
Pull Request Test Coverage Report for Build 5192440269
💛 - Coveralls |
imobachgs
approved these changes
Jun 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a new ruby-dbus in OBS, it turns out I only ran manual Agama tests, not the RSpec tests, which relied on ruby-dbus internals, so more fixes are needed
(Where exactly is is failing?)
Solution
In tests, replace
DBus::Serviceby one of its successors,ProxyServiceorObjectServerFor Questions which have a more complex test, fix more.
Testing
cd service; bundle exec rspec