Conversation
|
Changes unknown |
This reverts commit 7872d26.
jreidinger
reviewed
Jun 8, 2023
| jobs: | ||
| update_staging_package: | ||
| # do not run in forks | ||
| if: github.repository == 'openSUSE/agama' |
Contributor
There was a problem hiding this comment.
should we here also force only master branch?
imobachgs
approved these changes
Jun 8, 2023
Contributor
imobachgs
left a comment
There was a problem hiding this comment.
Thanks a lot! It looks great and it is well-documented. Great job!
| spec.version = File.read("VERSION").chomp | ||
| # the version is <version_tag>.devel<number_of_commits_since_the_tag> | ||
| # or just <version_tag> if there are no additional commits | ||
| spec.version = `git describe --tags`.chomp.sub(/^v/, "").sub(/-([0-9]+)-g\h+\Z/, ".devel\\1") |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Notes
As the GitHub workflow is executed only for the master branch there is no run for the last commits. If you want to see an example run check the actions history where I enabled the run also for the branch for this pull request.
The
rake osc:commitby default callsosc:buildtarget as a dependency. But building the Ruby gem package does not provide much value (it basically just unpack the files from*.gemto/usr/lib64/ruby...and compress that to an RPM). It just makes the submission much longer (1min -> 3mins).Additional Changes
--localoption when building the Ruby gem, it is much faster (1sec vs. 15sec) and the generated file is the sameTasks
agama-clipackagecockpit-agamapackagecockpit-agama-playwrightpackagerubygem-agamapackage