Skip to content

Improve the yupdate scripts#591

Merged
lslezak merged 1 commit intomasterfrom
yupdate_fix
May 25, 2023
Merged

Improve the yupdate scripts#591
lslezak merged 1 commit intomasterfrom
yupdate_fix

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented May 25, 2023

Problem

  • The yupdate script might fail when installing the missing packages because the Agama service can hold the libzypp lock

Solution

  • Stop the Agama service to possibly release the libzypp lock, start it back after installing the packages

Additional Fixes

  • Use set -e to fail on error
  • Use set -x when $DEBUG is set to 1 for debugging

Testing

  • Tested manually

@lslezak
Improve the yupdate scripts
c926097 
- Stop the Agama service to possibly release the libzypp lock
- Use "set -e" to fail on error
- Use "set -x" when $DEBUG is set to "1" for debugging
joseivanlopez
joseivanlopez approved these changes May 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 699857f into master May 25, 2023
@lslezak lslezak deleted the yupdate_fix branch May 25, 2023 14:30
@coveralls
Copy link
Copy Markdown

coveralls commented May 25, 2023

Pull Request Test Coverage Report for Build 5081143094

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.2%) to 66.489%
Totals Coverage Status
Change from base Build 5071759402: -9.2%
Covered Lines: 1788
Relevant Lines: 2557
💛 - Coveralls

@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

@joseivanlopez joseivanlopez joseivanlopez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lslezak @coveralls @imobachgs @joseivanlopez