[web] Increase the z-index of the sidebar#569
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
imobachgs
approved these changes
May 10, 2023
To avoid other elements overlapping it. A very high value was chosen because PatternFly uses values from 100 to 600 at the time of writing. See [1] Another option could be to use the PatternFly highest value, but for now it does not seem necessary to couple the Sidebar z-index to a PatternFly variable. [1] https://github.com/patternfly/patternfly/blob/7ddc2de5cfb96f204e62730878a9e77bed64b998/src/patternfly/sass-utilities/scss-variables.scss#L154-L160
dgdavid
force-pushed
the
fix-sidebar-z-index
branch
from
651195b to
a25ac3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The component used for displaying the page options has a higher
z-indexthan the Sidebar. This combined with the fact that the component it isn't closed automatically when the user clicks outside can lead to a situation of having the sidebar open but the page menu options on top.Solution
Use a higher value for the Sidebar
z-index. More specifically, the1000value because PatternFly uses values from 100 to 600 at the time of writing. SeeAnother option could be to use the PatternFly highest value, but IMHO it does not seem necessary to couple the Sidebar
z-indexto a PatternFly variable. At least for now.Testing
Screenshots