Conversation
Pull Request Test Coverage Report for Build 4668408668
💛 - Coveralls |
ancorgs
added a commit
that referenced
this pull request
Dec 20, 2024
## Problem Backend expects a prefix length instead of netmask, but unfortunately current code base is not ensuring of making the conversion before sending a request, making the connection form fail silently. ## Solution Adapt the `formatIp` util method for relying in `ipPrefixFor` to make such a conversion. ## Testing - Updated unit test - Tested manually --- Fixes #1846 Related to #530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agama does not handle correctly the IP address netmask but works fine when a prefix length is used.
Solution
When a connection is updated it always expect a prefix length but in the IP Input form it is allowed to use a netmask or a prefix length.
Therefore, the code has been adapted converting the netmask to a prefix length when needed.
Testing