Merged
Conversation
joseivanlopez
force-pushed
the
storage-reprobing
branch
from
f4b54e6 to
ae145fe
Compare
- Probing storage always reuses the previous proposal settings, if any.
- Styles should be moved to a class
- Note: there is an error message if the candidate device is not found
joseivanlopez
force-pushed
the
storage-reprobing
branch
from
a89748f to
eea3ba7
Compare
- The default device was not selected when the candidate device is missing.
- Components are mounted twice, which poduces some side effects as calling to probe system twice.
joseivanlopez
force-pushed
the
storage-reprobing
branch
from
eea3ba7 to
070df98
Compare
imobachgs
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Support for configuring iSCSI targets was already added, and DASD is coming soon. But the system is not re-probed after activating/deactivating devices, which implies the new disks cannot not be selected for installation. Moreover, the current selected disk could not be available anymore, for example, if an iSCSI session is closed.
Solution
Add a mechanism for reprobing after changing the system. Now, if an iSCSI session is created or closed, the system is marked as deprecated. That information can be used for clients to know if a reprobing is needed. The web UI automatically executes a reprobing when the system becomes deprecated.
Note: re-probing always reuse the settings from the previous storage proposal in order to keep the configuration set by the user. And the settings are reset if the product changes (a new product must always start from scratch).
Issue to reevalute this approach: #498.
Testing