Adapt storage web client#441
Merged
joseivanlopez merged 6 commits intoagama-project:masterfrom Mar 3, 2023
Merged
Conversation
joseivanlopez
force-pushed
the
storage-client
branch
3 times, most recently
from
baa555f to
8bfadc2
Compare
joseivanlopez
force-pushed
the
storage-client
branch
2 times, most recently
from
19a6d34 to
0d84975
Compare
joseivanlopez
force-pushed
the
storage-client
branch
2 times, most recently
from
e9d4187 to
21024c0
Compare
imobachgs
approved these changes
Mar 3, 2023
| * @returns {object} | ||
| */ | ||
| class StorageBaseClient { | ||
| const removeUndefinedCockpitProperties = (cockpitObject) => { |
Contributor
There was a problem hiding this comment.
It looks like a generic function that might be useful in other parts. Of course, it can live here by now, but it will be reusable in the future (when we add support for more iSCSI-like APIs). And when we move that function, we could extend it to work on nested objects.
joseivanlopez
force-pushed
the
storage-client
branch
from
21024c0 to
395b805
Compare
dgdavid
requested changes
Mar 3, 2023
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
What about changes files?
Contributor
It is part of the iSCSI support, so I do not think it is needed yet. |
joseivanlopez
force-pushed
the
storage-client
branch
from
8ce1da9 to
ef19090
Compare
joseivanlopez
force-pushed
the
storage-client
branch
from
ef19090 to
cb902b5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The D-Bus API of the storage service was modified and extended to support iSCSI. The storage D-Bus client used by the web client needs to be adapted in order to provide all the required features to build an iSCSI UI.
Solution
Adapt the storage D-Bus client to all the changes in the D-Bus API. Moreover, this PR extends the storage D-Bus API to provide some missing features (e.g., iBFT property).
Testing