[web] Use a specific manifest.json file for development#422
Merged
Conversation
imobachgs
reviewed
Feb 13, 2023
d2cbee9 to
613ad4b
Compare
To not change the content-security-policy in production.
613ad4b to
91c8052
Compare
imobachgs
approved these changes
Feb 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We've changed the
content-security-policyin #419 via manifest file for allowing HMR. However, that change must not reach a production environment.Solution
Added a
manifest.dev.jsonand keepmanifest.jsonas it was. Depending on theNODE_ENVvalue the resulting div/manifest.json will contain the proper settings.Testing
Tested manually by running
npm run buildandNODE_ENV=production npm run buildand checking the content of the dist/manifest.json