Skip to content

Comments

[web] Use a specific manifest.json file for development#422

Merged
imobachgs merged 1 commit intomasterfrom
fix-manifest
Feb 13, 2023
Merged

[web] Use a specific manifest.json file for development#422
imobachgs merged 1 commit intomasterfrom
fix-manifest

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Feb 13, 2023

Problem

We've changed the content-security-policy in #419 via manifest file for allowing HMR. However, that change must not reach a production environment.

Solution

Added a manifest.dev.json and keep manifest.json as it was. Depending on the NODE_ENV value the resulting div/manifest.json will contain the proper settings.

Testing

Tested manually by running npm run build and NODE_ENV=production npm run build and checking the content of the dist/manifest.json

@dgdavid dgdavid requested a review from imobachgs February 13, 2023 13:12
@coveralls
Copy link

coveralls commented Feb 13, 2023

Coverage Status

Coverage: 77.784%. Remained the same when pulling 91c8052 on fix-manifest into ad0580d on master.

To not change the content-security-policy in production.
@imobachgs imobachgs merged commit 5ad6f97 into master Feb 13, 2023
@imobachgs imobachgs deleted the fix-manifest branch February 13, 2023 15:15
@imobachgs imobachgs mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants