Merged
Conversation
By default, webpack does not clean up dist/, so when you e.g. touch the code and rebuild with `NODE_ENV=devel`, the old compressed assets from a previous `production` build were left in place, and cockpit could serve the old wrong ones. Enable the `clean` output option to fix this [1]. Also force the rewrite of all files with `compareBeforeEmit: false`, so that the time stamps actually get updated on a webpack run. This fixes `make` rules and unnecessary rebuilds when nothing changed. Fixes #563 [1] https://webpack.js.org/configuration/output/#outputclean
Include CSS linting by default for our CSS/SCSS files, originally introduced in cockpit. The stylelint configuration is copied from 760a4628282e02fbcef3.
dgdavid
commented
Jan 25, 2023
| } | ||
|
|
||
| section > svg { | ||
| grid-aread: icon; |
Contributor
Author
There was a problem hiding this comment.
Nice linter catch around here 😅
dgdavid
force-pushed
the
sync-starter-kit-webpack
branch
from
ef20fe3 to
e5fcdde
Compare
Contributor
|
It is a good idea to keep this stuff in sync. IMHO, we should add the style linter to our CI workflow. |
Contributor
Author
Done. Thanks for remembering it. |
Contributor
Author
Agree. But what do you think about cockpit-project/starter-kit@b3a9565? Does it look needed for you? |
dgdavid
changed the title
imobachgs
approved these changes
Feb 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Not a problem, but a suggestion: to keep our webpack config file in sync with the Cockpit Starter Kit counterpart as much as possible.
At this moment, we're three commits behind, namely:
Solution
To apply them
Pending
Not sure if the second one (build: don't move pkg/lib/ to src/lib/) proceeds here
Testing